Update the minimum_wp_version to WP 6.6#2656
Conversation
The minimum version should be three versions behind the latest WP release, so what with 6.9.0 slated for release on Dec 2nd, it should now become 6.6. Includes updating the tests to match. Previous: 2121, 2321. 2436, 2553
rodrigoprimo
left a comment
rodrigoprimo
left a comment
There was a problem hiding this comment.
Looks good to me!
The only question that I have is if this PR should also update phpcs.xml.dist.simple to bump the value of the minimum_wp_version property to 6.6 and testVersion to 7.2- (as WP 6.6 dropped support for PHP 7.0 and 7.1)? Or is the plan to address this separately?
@rodrigoprimo This setting vs the example file are two different decision points:
Updating those could potentially be combined in one PR, but updating the setting is something which MUST be done regularly for accurate scan results, while updating the example file has no consequences whatsoever and is something to do when someone thinks of it. Also note that the example file was already updated recently via PR #2608 (first update in three years), so I don't have any plans to address this separately - or at all - in the foreseeable future. If you believe the setting and the example file should be tightly coupled, I suggest you submit a PR to update the release checklist proposing that and sync the example file while you are at it. 🤷🏻♀️ |
I opened a PR with those changes: #2662 |
4 participants
Description
The minimum version should be three versions behind the latest WP release, so what with 6.9.0 slated for release on Dec 2nd, it should now become 6.6.
Includes updating the tests to match.
Suggested changelog entry
Changed
minimum_wp_version, as used by a number of sniffs detecting usage of deprecated WP features, has been updated to6.6.Related issues/external references
Previous: #2121, #2321. #2436, #2553